Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix]AudioSession management via CallSettings #585

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[Fix]AudioSession management via CallSettings #585

wants to merge 2 commits into from

Conversation

ipavlidakis
Copy link
Collaborator

🔗 Issue Links

Resolves https://stream-io.atlassian.net/browse/PBE-6278

📝 Summary

This revision provides a consistent way of managing the AudioSession from CallSettings updates.

🧪 Manual Testing Notes

  • Join a call
  • Mute/unmute your self a few times and verify things are working expected
  • While unmuted
  • Toggle the speaker and verify it works
  • With the speaker on, mute your mic and verify it works
  • Unmute your mic and verify speaker is on

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

@ipavlidakis ipavlidakis added the bug Something isn't working label Oct 24, 2024
@ipavlidakis ipavlidakis self-assigned this Oct 24, 2024
@ipavlidakis ipavlidakis requested a review from a team as a code owner October 24, 2024 09:36
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Oct 24, 2024 •
edited
Loading

SDK Size

title develop branch diff status
StreamVideo 7.44 MB 7.46 MB +20 KB 🟢
StreamVideoSwiftUI 2.18 MB 2.18 MB -1 KB 🚀
StreamVideoUIKit 2.31 MB 2.31 MB -1 KB 🚀
StreamWebRTC 8.69 MB 8.69 MB 0 KB 🟢

martinmitrevski
martinmitrevski approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me codewise. Some checks are failing. Let's test this on our call and then merge it.

@github-actions GitHub Actions
Copy link

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipavlidakis @Stream-SDK-Bot @martinmitrevski